chore(ci): disable fail-fast on matrix tests #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
+ Coverage 51.73% 51.79% +0.05%
==========================================
Files 167 167
Lines 10806 10806
==========================================
+ Hits 5591 5597 +6
+ Misses 4723 4720 -3
+ Partials 492 489 -3 |
ramin
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
approved these changes
Nov 10, 2023
vgonkivs
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable "fail-fast" so if the
ubuntu-latestmatrix unit test fails then it wont cancel the run ofmacos-latest, this will help with easing ability to merge as we've reduced the requirement for both to merge