docker: Create a single Dockerfile that works for full and light celestia-nodes

[jbowen93]

Create a new Dockerfile that works for both celestia-node full and light nodes while matching the expectations of both the docker-compose and k8s cluster setups.

At runtime the a NODE_TYPE environment variable matching either full or light is expected.

If not provided it defaults to full.

For examples see the docker-compose config and the k8s config.

This has been manually tested by building the Docker image

docker build -f docker/Dockerfile -t jbowen93/celestia-node:multi

and then testing it with docker-compose

cd devnet
./start-docker.sh

and with kubernetes

cd devnet
kubectl create -f k8s/core-nodes -R && \
sleep 45s && \
kubectl create -f k8s/light-nodes -R

[renaynay]

Thank you so much for this @jbowen93

Can you change the name of the dockerfile to bridge.Dockerfile since this will be called a bridge node? Similarly after merging #294, the NODETYPE will have to be bridge.

[jbowen93]

Thank you so much for this @jbowen93

Can you change the name of the dockerfile to bridge.Dockerfile since this will be called a bridge node? Similarly after merging #294, the NODETYPE will have to be bridge.

I don't believe we should change the name of the Dockerfile. This Dockerfile is intentionally designed to work with both full nodes (now bridge nodes) and light nodes, you just pass different environment variables and startup commands. See an example of a full/bridge node and a light node.

Also keep in mind that the env vars set in the Dockerfile are only defaults that should be overwritten later. From the docs:

When you set the same environment variable in multiple files, here’s the priority used by Compose to choose which value to use:

Compose file
Shell environment variables
Environment file
Dockerfile
Variable is not defined

[jbowen93]

Lint should be resolved after #308 is merged

[renaynay]

I don't believe we should change the name of the Dockerfile. This Dockerfile is intentionally designed to work with both full nodes (now bridge nodes) and light nodes, you just pass different environment variables and startup commands. See an example of a full/bridge node and a light node.

@jbowen93 Okay as long as eventually we have automation for pushing three different images to dockerhub on release, one for bridge, full, and light so that people can just pull and run.

[jbowen93]

I don't believe we should change the name of the Dockerfile. This Dockerfile is intentionally designed to work with both full nodes (now bridge nodes) and light nodes, you just pass different environment variables and startup commands. See an example of a full/bridge node and a light node.

@jbowen93 Okay as long as eventually we have automation for pushing three different images to dockerhub on release, one for bridge, full, and light so that people can just pull and run.

Just clarifying some more. This image supports multiple node types at run time. There is no need to push different images.

Full node (will rename to bridge)

 docker run --network docker_localnet -e NODE_TYPE=full \
 jbowen93/celestia-node:multi celestia full --repo.path /celestia-full start \
 --core.remote tcp://192.167.10.2:26657 \
 --headers.trusted-hash "64D831D041A57A9D93078B445F7B1347024A9B5A8A444086C0B556B65A8A96C7" \
 --p2p.mutual "/ip4/192.167.10.7/tcp/2121/p2p/12D3KooWGGtejCnY3Q9XUUy6muSRm1Whgf8ijTRtwJ8DGA1164EB,/ip4/192.167.10.8/tcp/2121/p2p/12D3KooWQCbe8R4QD1jxnUs5SWWdFg5Kza3mBE94Cz1RJnLTXfNM,/ip4/192.167.10.9/tcp/2121/p2p/12D3KooWA6uovjYCgFvWhAbrcQmnLihFy1gZkdyJt8SrPKZjeWda"

light node

docker run --network docker_localnet -e NODE_TYPE=light \
jbowen93/celestia-node:multi celestia light --repo.path /celestia-light \
start --headers.trusted-peer "/ip4/192.167.0.2/tcp/2121/p2p/12D3KooWHLnz72q5mmCBooVbkjNcSWTzhEsc6gtSPwCqgervgNnb" \
 --headers.trusted-hash "64D831D041A57A9D93078B445F7B1347024A9B5A8A444086C0B556B65A8A96C7"

I did a quick manual test for this:

1. Set up the core nodes with docker-compose docker/core-docker-compose.yml up
2. Run the above full node docker run command
3. Retrieve the ip address of the full node by looking through docker network inspect docker_localnet
4. Get the peer id for the full node. I ran docker logs a345973ca120 2> /dev/null for this
5. Run the above light node docker run command