chore(utils): test sanitizing empty addr #2998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estensen
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
ramin
requested changes
Dec 11, 2023
There was a problem hiding this comment.
this is cool, lets go a step further, and create a named var in the address.go file (ErrInvalidIP maybe) then instead of the expErr being a bool, we can make it an error and give it nil or the expected error and test require.EqualErorr or similar as part of the test, then we can skip the !tt.expErr and just test that its nil or the ErrInvalidIP
estensen
commented
Dec 14, 2023
Comment on lines
32
to
+38
| require.Equal(t, tt.want, got) | ||
| if tt.err != nil { | ||
| require.Error(t, err) | ||
| require.True(t, errors.Is(err, tt.err)) | ||
| } else { | ||
| require.NoError(t, err) | ||
| } |
There was a problem hiding this comment.
Wanted this
require.Equal(t, tt.want, got)
require.ErrorIs(t, tt.err, err)But couldn't get it to work
Error: Target error should be in err chain:
expected: "invalid IP address or hostname given: "
in chain: "invalid IP address or hostname given"
Test: TestSanitizeAddr/#00
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
==========================================
- Coverage 50.96% 50.76% -0.21%
==========================================
Files 168 168
Lines 11038 11022 -16
==========================================
- Hits 5626 5595 -31
- Misses 4908 4928 +20
+ Partials 504 499 -5 ☔ View full report in Codecov by Sentry. |
renaynay
reviewed
Dec 21, 2023
Comment on lines
+33
to
+38
| if tt.err != nil { | ||
| require.Error(t, err) | ||
| require.True(t, errors.Is(err, tt.err)) | ||
| } else { | ||
| require.NoError(t, err) | ||
| } |
There was a problem hiding this comment.
You can simplify this by just doing assert.ErrorIs(t, err, tt.err)
ramin
added a commit
that referenced
this pull request
Jan 8, 2024
<!-- Thank you for submitting a pull request! Please make sure you have reviewed our contributors guide before submitting your first PR. Please ensure you've addressed or included references to any related issues. Tips: - Use keywords like "closes" or "fixes" followed by an issue number to automatically close related issues when the PR is merged (e.g., "closes #123" or "fixes #123"). - Describe the changes made in the PR. - Ensure the PR has one of the required tags (kind:fix, kind:misc, kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci, kind:chore, kind:testing) --> in kind replacement of #2998 with the simplified require assertion --------- Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com>
distractedm1nd
pushed a commit
that referenced
this pull request
Jan 10, 2024
<!-- Thank you for submitting a pull request! Please make sure you have reviewed our contributors guide before submitting your first PR. Please ensure you've addressed or included references to any related issues. Tips: - Use keywords like "closes" or "fixes" followed by an issue number to automatically close related issues when the PR is merged (e.g., "closes #123" or "fixes #123"). - Describe the changes made in the PR. - Ensure the PR has one of the required tags (kind:fix, kind:misc, kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci, kind:chore, kind:testing) --> in kind replacement of #2998 with the simplified require assertion --------- Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com>
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 15, 2024
<!-- Thank you for submitting a pull request! Please make sure you have reviewed our contributors guide before submitting your first PR. Please ensure you've addressed or included references to any related issues. Tips: - Use keywords like "closes" or "fixes" followed by an issue number to automatically close related issues when the PR is merged (e.g., "closes #123" or "fixes #123"). - Describe the changes made in the PR. - Ensure the PR has one of the required tags (kind:fix, kind:misc, kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci, kind:chore, kind:testing) --> in kind replacement of celestiaorg#2998 with the simplified require assertion --------- Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com>
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 15, 2024
<!-- Thank you for submitting a pull request! Please make sure you have reviewed our contributors guide before submitting your first PR. Please ensure you've addressed or included references to any related issues. Tips: - Use keywords like "closes" or "fixes" followed by an issue number to automatically close related issues when the PR is merged (e.g., "closes #123" or "fixes #123"). - Describe the changes made in the PR. - Ensure the PR has one of the required tags (kind:fix, kind:misc, kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci, kind:chore, kind:testing) --> in kind replacement of celestiaorg#2998 with the simplified require assertion --------- Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage to the non-happy path