Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nodebuilder/state): SubmitTx endpoint takes read-level permissions #3072

Merged
merged 11 commits into from
Jan 19, 2024
Merged

chore(nodebuilder/state): SubmitTx endpoint takes read-level permissions #3072

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d12b858
changing SubmitTX to read permissions
moldis Jan 8, 2024
21402e8
Merge branch 'celestiaorg:main' into feature/submit-tx-read-perm
nodersteam Jan 8, 2024
d846639
lint fix
moldis Jan 8, 2024
c021afa
Merge branch 'celestiaorg:main' into feature/submit-tx-read-perm
nodersteam Jan 8, 2024
eeaece6
removing based on PR comments
moldis Jan 10, 2024
1489ae4
Merge branch 'main' into feature/submit-tx-read-perm
nodersteam Jan 10, 2024
a6df95a
Merge branch 'main' into feature/submit-tx-read-perm
nodersteam Jan 11, 2024
7b22846
Merge branch 'celestiaorg:main' into feature/submit-tx-read-perm
nodersteam Jan 15, 2024
2913ca0
Merge branch 'main' into feature/submit-tx-read-perm
ramin Jan 16, 2024
efed5f7
Merge branch 'main' into feature/submit-tx-read-perm
ramin Jan 16, 2024
ffe810d
Merge branch 'main' into feature/submit-tx-read-perm
renaynay Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions api/rpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,21 +177,35 @@ func TestAuthedRPC(t *testing.T) {
stats, err := rpcClient.DAS.SamplingStats(ctx)
require.NoError(t, err)
require.Equal(t, expected, stats)

expectedResp := &state.TxResponse{}
server.State.EXPECT().SubmitTx(gomock.Any(),
gomock.Any()).Return(expectedResp, nil)
txResp, err := rpcClient.State.SubmitTx(ctx, []byte{})
require.NoError(t, err)
require.Equal(t, expectedResp, txResp)
moldis marked this conversation as resolved.
Show resolved Hide resolved
} else {
_, err := rpcClient.DAS.SamplingStats(ctx)
require.Error(t, err)
require.ErrorContains(t, err, "missing permission")

_, err = rpcClient.State.SubmitTx(ctx, []byte{})
require.Error(t, err)
require.ErrorContains(t, err, "missing permission")
moldis marked this conversation as resolved.
Show resolved Hide resolved
}

// 2. Test method with write-level permissions
expectedResp := &state.TxResponse{}
if tt.perm > 2 {
server.State.EXPECT().SubmitTx(gomock.Any(), gomock.Any()).Return(expectedResp, nil)
txResp, err := rpcClient.State.SubmitTx(ctx, []byte{})
server.State.EXPECT().Delegate(gomock.Any(), gomock.Any(),
gomock.Any(), gomock.Any(), gomock.Any()).Return(expectedResp, nil)
txResp, err := rpcClient.State.Delegate(ctx,
state.ValAddress{}, state.Int{}, state.Int{}, 0)
require.NoError(t, err)
require.Equal(t, expectedResp, txResp)
} else {
_, err := rpcClient.State.SubmitTx(ctx, []byte{})
_, err := rpcClient.State.Delegate(ctx,
state.ValAddress{}, state.Int{}, state.Int{}, 0)
require.Error(t, err)
require.ErrorContains(t, err, "missing permission")
}
Expand Down
2 changes: 1 addition & 1 deletion nodebuilder/state/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ type API struct {
fee state.Int,
gasLimit uint64,
) (*state.TxResponse, error) `perm:"write"`
SubmitTx func(ctx context.Context, tx state.Tx) (*state.TxResponse, error) `perm:"write"`
SubmitTx func(ctx context.Context, tx state.Tx) (*state.TxResponse, error) `perm:"read"`
SubmitPayForBlob func(
ctx context.Context,
fee state.Int,
Expand Down
Loading