feat(core)!: separating core.ip into core.grpc.ip and core.rpc.ip #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
area:core_and_app
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
ramin
as code owners
ramin
approved these changes
Feb 1, 2024
ramin
reviewed
Feb 1, 2024
|
What do you mean by IP switching? ParseFlags? |
|
replaced by #3242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2931, although I fail to understand the requirements for the second todo, so can add next.
Breaks config by changing
core.IP-> (core.RPCIP,core.GRPCIP).We keep the
--core.ipflag, which lets the user set both IPs at once. But it cannot be passed together with either of the new flags.Failure cases:
