misc(blob/service)!: return empty values in case blobs were not found #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd,
walldiss and
ramin
as code owners
ramin
previously approved these changes
Mar 1, 2024
Wondertan
previously approved these changes
Mar 1, 2024
|
This is technically API breaking as someone could depend on the error, so we should mark it as so |
vgonkivs
changed the title
walldiss
previously approved these changes
Mar 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3223 +/- ##
==========================================
- Coverage 44.83% 44.50% -0.33%
==========================================
Files 265 273 +8
Lines 14620 15402 +782
==========================================
+ Hits 6555 6855 +300
- Misses 7313 7738 +425
- Partials 752 809 +57 ☔ View full report in Codecov by Sentry. |
vgonkivs
changed the title
Isn't this breaking? why were tags and ! removed? |
|
Reworked to non-breaking. |
|
makes sense, thanks! and in this feature, if there are no blobs, empty vector is returned? is there anything else that changes from a user perspective? |
ramin
previously approved these changes
Mar 8, 2024
distractedm1nd
previously approved these changes
Jul 3, 2024
ramin
previously approved these changes
Jul 3, 2024
vgonkivs
dismissed stale reviews from ramin, distractedm1nd, walldiss, and renaynay
via
8d78a3b
vgonkivs
requested review from
Wondertan,
ramin,
walldiss,
distractedm1nd and
renaynay
cristaloleg
reviewed
Jul 3, 2024
ramin
previously approved these changes
Jul 3, 2024
renaynay
reviewed
Jul 3, 2024
renaynay
previously approved these changes
Jul 3, 2024
renaynay
approved these changes
Jul 3, 2024
Wondertan
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3192 , #3292