Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): Unregister callback on stop for several metrics implementations #3281

Merged
merged 7 commits into from
Apr 21, 2024
Merged

fix(metrics): Unregister callback on stop for several metrics implementations #3281

merged 7 commits into from
Apr 21, 2024

Commits on Apr 18, 2024

  1. fix(metrics): ensure metric registration close on stop

    @renaynay
    renaynay committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dbe2b7a View commit details
    Browse the repository at this point in the history

  2. chore(share/eds/cache): EnableMetrics returns closer too

    @renaynay
    renaynay committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d0fe3d5 View commit details
    Browse the repository at this point in the history

  3. chore: Make metrics closing log warning instead of return err, consis… 

    …tency
    @renaynay
    renaynay committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    efa9646 View commit details
    Browse the repository at this point in the history

  4. fix: error -> warn

    @renaynay
    renaynay committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0f36037 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into unregister-meter

    @renaynay
    renaynay committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4a673c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Merge branch 'main' into unregister-meter

    @Wondertan
    Wondertan committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    382cd59 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into unregister-meter

    @Wondertan
    Wondertan committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    1920828 View commit details
    Browse the repository at this point in the history