fix(core): Unsubscribe from new block event on Stop in listener #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:core_and_app
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3315 +/- ##
==========================================
+ Coverage 44.83% 45.14% +0.30%
==========================================
Files 265 272 +7
Lines 14620 15064 +444
==========================================
+ Hits 6555 6800 +245
- Misses 7313 7498 +185
- Partials 752 766 +14 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Apr 17, 2024
walldiss
approved these changes
Apr 17, 2024
vgonkivs
approved these changes
Apr 17, 2024
Wondertan
pushed a commit
that referenced
this pull request
Apr 21, 2024
Subscription was never cancelled on Stop, found while working on swamp tests for #3188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscription was never cancelled on Stop, found while working on swamp tests for #3188