chore(fmt/linters): enable nilerr, nilnil, nolintlint and fix related issues #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
ramin
as code owners
Wondertan
reviewed
Apr 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3332 +/- ##
==========================================
- Coverage 44.83% 44.66% -0.18%
==========================================
Files 265 273 +8
Lines 14620 15202 +582
==========================================
+ Hits 6555 6790 +235
- Misses 7313 7627 +314
- Partials 752 785 +33 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Apr 26, 2024
vgonkivs
approved these changes
Apr 29, 2024
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
May 7, 2024
… issues (celestiaorg#3332) Enables nilerr, nilnil, nolintlint checks as well as fixing issues found by those linters (cherry picked from commit a25773c)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
May 7, 2024
… issues (celestiaorg#3332) Enables nilerr, nilnil, nolintlint checks as well as fixing issues found by those linters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables nilerr, nilnil, nolintlint checks as well as fixing issues found by those linters