chore(linter): add 6 more linteres #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
ramin
as code owners
|
@walldiss, linter fails |
vgonkivs
previously approved these changes
Apr 29, 2024
|
Linter failed |
vgonkivs
approved these changes
Apr 29, 2024
Wondertan
approved these changes
Apr 29, 2024
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
May 7, 2024
Adds linters : - whitespace - protogetter - wastedassign - gocheckcompilerdirectives - loggercheck - bidichk - exportloopref Also fixes found issues by each linter (cherry picked from commit 2d2adb3)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
May 7, 2024
Adds linters : - whitespace - protogetter - wastedassign - gocheckcompilerdirectives - loggercheck - bidichk - exportloopref Also fixes found issues by each linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds linters :
Also fixes found issues by each linter
Depends on #3331, as some issues for added linters were solved there.