Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linters): add errorlint #3334

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

walldiss
Copy link
Member

Adds errorlint linter and fixes related issues

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 13.04348% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 44.60%. Comparing base (2469e7a) to head (e5fadd8).
Report is 40 commits behind head on main.

Files Patch % Lines
nodebuilder/state/cmd/state.go 0.00% 34 Missing ⚠️
nodebuilder/blob/cmd/blob.go 0.00% 10 Missing ⚠️
api/gateway/availability.go 0.00% 3 Missing ⚠️
cmd/rpc.go 0.00% 3 Missing ⚠️
nodebuilder/p2p/addrs.go 0.00% 3 Missing ⚠️
nodebuilder/header/cmd/header.go 0.00% 2 Missing ⚠️
share/eds/ods.go 0.00% 2 Missing ⚠️
nodebuilder/header/service.go 0.00% 1 Missing ⚠️
nodebuilder/p2p/config.go 0.00% 1 Missing ⚠️
share/p2p/shrexnd/client.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3334      +/-   ##
==========================================
- Coverage   44.83%   44.60%   -0.24%     
==========================================
  Files         265      273       +8     
  Lines       14620    15255     +635     
==========================================
+ Hits         6555     6804     +249     
- Misses       7313     7663     +350     
- Partials      752      788      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walldiss walldiss added kind:testing Related to unit tests and removed kind:testing Related to unit tests labels Apr 23, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice1

@walldiss walldiss enabled auto-merge (squash) April 29, 2024 06:30
@walldiss walldiss merged commit b241223 into celestiaorg:main Apr 29, 2024
25 checks passed
walldiss added a commit to walldiss/celestia-node that referenced this pull request May 7, 2024
Adds errorlint linter and fixes related issues

(cherry picked from commit b241223)
walldiss added a commit to walldiss/celestia-node that referenced this pull request May 7, 2024
Adds errorlint linter and fixes related issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants