Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pruner/light): Fix light availability window provided #3370

Merged
merged 5 commits into from
May 7, 2024

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented May 6, 2024

Thank you @walldiss for finding this.

@renaynay renaynay added area:storage kind:fix Attached to bug-fixing PRs labels May 6, 2024
@renaynay renaynay self-assigned this May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.51%. Comparing base (2469e7a) to head (92cd68a).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3370      +/-   ##
==========================================
- Coverage   44.83%   44.51%   -0.32%     
==========================================
  Files         265      273       +8     
  Lines       14620    15255     +635     
==========================================
+ Hits         6555     6791     +236     
- Misses       7313     7676     +363     
- Partials      752      788      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

walldiss
walldiss previously approved these changes May 6, 2024
pruner/light/window.go Outdated Show resolved Hide resolved
Wondertan
Wondertan previously approved these changes May 6, 2024
@renaynay renaynay dismissed stale reviews from Wondertan and walldiss via ed10c1f May 6, 2024 13:03
@renaynay renaynay requested a review from walldiss May 6, 2024 13:03
walldiss
walldiss previously approved these changes May 6, 2024
@renaynay renaynay changed the title fix(pruner/light): Include time.Second fix(pruner/light): Fix light availability window provided May 6, 2024
Wondertan
Wondertan previously approved these changes May 6, 2024
walldiss
walldiss previously approved these changes May 6, 2024
@renaynay renaynay dismissed stale reviews from walldiss and Wondertan via 92cd68a May 6, 2024 16:26
@renaynay renaynay requested a review from MSevey May 6, 2024 16:32
@renaynay renaynay enabled auto-merge (squash) May 7, 2024 13:51
@renaynay renaynay merged commit b64f947 into celestiaorg:main May 7, 2024
26 checks passed
@renaynay renaynay deleted the fix-avail-window branch May 7, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:storage kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants