-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade to celestia-app v2.0.0-rc2 #3453
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
NamespaceId: namespace.ID(), | ||
Data: data, | ||
ShareVersion: uint32(shareVersion), | ||
NamespaceVersion: uint32(namespace.Version()), | ||
} | ||
|
||
com, err := types.CreateCommitment(&blob) | ||
com, err := inclusion.CreateCommitment(&blob, merkle.HashFromByteSlices, appconsts.SubtreeRootThreshold(v1.Version)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[for reviewers] Invoking with v1.Version
behaves identically to invoking with v2.Version
because the implementation of this function doesn't actually care about the version that is provided as an argument.
blob/blobtest/testing.go:31:25: copylocks: call of append copies lock value: github.com/celestiaorg/go-square/blob.Blob contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet) blobs = append(blobs, *appBlob)
This comment was marked as outdated.
This comment was marked as outdated.
There's a TODO that states celestia-app isn't set up. The assertion fails because the min gas price returned is "" even though the app config attempts to set it to .002
because it doesn't appear to be compiled based on build flags
…custom chain-ids" This reverts commit a5650ac.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
|
Update celestia-node to use celestia-app v2.0.0-rc2. A few changes that were needed:
CreateCommitment
. celestia-app v2.x usesCreateCommitment
from the go-square inclusion package.header.Version.App = 2
. Added unit tests.signer
. celestia-app v2.x split atxClient
from thesigner
. See: feat: add multi-account support celestia-app#3433I had to updatecore_access.go
a lot. Mostly inspired by feat: support multiple accounts #3451Testing
I ran a script with: celestia-app v2.0.0-rc2 and configured it to upgrade at block height 3. celestia-node (built from this PR) continued to work: