Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodebuilder/share): Pass light.Window to shrex getter construction regardless of node type / pruning mode #3466

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Jun 4, 2024

Since it is a network constant, shrex getter request routing should be based on the hardcoded light.Window rather than the avail window that is passed to it. light.Window should be used network-wide to determine which peer pool (full or archival) would be most likely to serve the request.

This also fixes a bug where archival nodes would not route historic EDS requests to the archival pool due to AvailabilityWindow being 0.

@renaynay renaynay added area:p2p kind:fix Attached to bug-fixing PRs shrex For issues and PRs related to shrex protocol labels Jun 4, 2024
@renaynay renaynay self-assigned this Jun 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.60%. Comparing base (2469e7a) to head (6f4c5ca).
Report is 104 commits behind head on main.

Files Patch % Lines
nodebuilder/share/module.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3466      +/-   ##
==========================================
- Coverage   44.83%   44.60%   -0.24%     
==========================================
  Files         265      273       +8     
  Lines       14620    15369     +749     
==========================================
+ Hits         6555     6855     +300     
- Misses       7313     7719     +406     
- Partials      752      795      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renaynay renaynay enabled auto-merge (squash) June 6, 2024 13:09
@renaynay renaynay merged commit bdac1d7 into celestiaorg:main Jun 6, 2024
24 of 25 checks passed
@Wondertan Wondertan deleted the hardcode-light branch June 6, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:p2p kind:fix Attached to bug-fixing PRs shrex For issues and PRs related to shrex protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants