feat(docgen): improve examples #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss,
ramin and
cristaloleg
as code owners
cristaloleg
reviewed
Jun 8, 2024
distractedm1nd
force-pushed
the
better-examples
branch
from
8a8d220
to
a9c1d24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3479 +/- ##
==========================================
- Coverage 44.83% 44.72% -0.12%
==========================================
Files 265 273 +8
Lines 14620 15383 +763
==========================================
+ Hits 6555 6880 +325
- Misses 7313 7702 +389
- Partials 752 801 +49 ☔ View full report in Codecov by Sentry. |
distractedm1nd
force-pushed
the
better-examples
branch
from
a9c1d24
to
417d347
Compare
vgonkivs
approved these changes
Jun 21, 2024
ramin
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved examples for blob related types to be consistent throughout (Commitment, Proof, Blob, Namespace). Previous blob.Proof and blob.Commitment were not valid values.
Also added a valid example value for libhead.Hash