chore(share/p2p/discovery): Change success case logging for advertisement to INFO level #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
vgonkivs
previously approved these changes
Jun 11, 2024
cristaloleg
previously approved these changes
Jun 11, 2024
cristaloleg
approved these changes
Jun 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3492 +/- ##
==========================================
- Coverage 44.83% 44.67% -0.17%
==========================================
Files 265 273 +8
Lines 14620 15371 +751
==========================================
+ Hits 6555 6867 +312
- Misses 7313 7707 +394
- Partials 752 797 +45 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These logs would happen infrequently anyway (hourly) and we only logged error case so would be nice to see the success case without having to enable debug logs.
Also some random linter failure fixes on my end.