fix(nodebuilder/core): non default values from config.toml are written over by flag defaults in specific circumstances #3526
Commits on Jun 25, 2024
-
fix core config flag parsing where, in specific circumstances, the va…
…lues from config.toml would be overwritten by defaults if any core.ip was provided as a cli flag
-
catch a fringe case where we parse in a core.ip, but also an empty co…
…nfig with no defaults (likely never happen)
Commits on Jun 26, 2024
-
implement @Wondertan's suggestion to let empty pass all the way and p…
…refer fail on validation, also fill out tests for Validate
-
Commits on Jun 27, 2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.