Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: GetSharesByNamespace - no error if namespace not found #679

Merged
merged 1 commit into from May 6, 2022
Merged

refactor: GetSharesByNamespace - no error if namespace not found #679

merged 1 commit into from May 6, 2022

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented May 6, 2022

@tzdybal tzdybal requested a review from liamsi as a code owner May 6, 2022 11:24
@tzdybal tzdybal self-assigned this May 6, 2022
Wondertan
Wondertan approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pls also rebase so that we have green lint hereafter #675 is merged.

@liamsi
Copy link
Member

liamsi commented May 6, 2022

Why not use that Update branch button instead of rebasing?

@tzdybal
refactor(service/share): GetSharesByNamespace - no error if namespace…
0d58b3a 
… not found

* This is simillar to changes introduced in #661 in IPLD package.
* Test was broken - `Error` checks for error and prints a message
  (there's `ErrorContains` for string comparison)
@Wondertan
Copy link
Member

@liamsi, let @tzdybal use what is most convenient for him. By saying "rebasing", I meant that the branch needs to be synced with the main and @tzdybal got what I meant

@Wondertan
Copy link
Member

The test failure is the known flakiness #608

@tzdybal
Copy link
Member Author

tzdybal commented May 6, 2022

I use ultimate solution - "Update with rebase" button 😂

@tzdybal tzdybal merged commit 81b8f87 into main May 6, 2022
@tzdybal tzdybal deleted the tzdybal/fix_assertion branch May 6, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

Assignees

@tzdybal tzdybal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzdybal @liamsi @Wondertan