Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header: Exchange interface implements Getter #842

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

renaynay
Copy link
Member

This PR changes Exchange interface to just implement Getter as they are performing the same functions just with different names.

@renaynay renaynay added area:header Extended header kind:misc Attached to miscellaneous PRs labels Jun 20, 2022
@renaynay renaynay self-assigned this Jun 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #842 (02287af) into main (643749f) will decrease coverage by 0.10%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   54.00%   53.90%   -0.11%     
==========================================
  Files         122      122              
  Lines        6979     6979              
==========================================
- Hits         3769     3762       -7     
- Misses       2823     2828       +5     
- Partials      387      389       +2     
Impacted Files Coverage Δ
header/local/exchange.go 68.42% <75.00%> (ø)
header/core/exchange.go 50.00% <80.00%> (ø)
header/p2p/exchange.go 62.22% <100.00%> (ø)
header/store/init.go 100.00% <100.00%> (ø)
header/sync/sync.go 65.34% <100.00%> (ø)
fraud/bad_encoding.go 40.59% <0.00%> (-2.98%) ⬇️
das/daser.go 73.68% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643749f...02287af. Read the comment docs.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this change, even though it has a low priority.

header/interface.go Show resolved Hide resolved
@renaynay renaynay merged commit a94fcb8 into celestiaorg:main Jun 27, 2022
@renaynay renaynay deleted the exchange-header-getter branch June 27, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:header Extended header kind:misc Attached to miscellaneous PRs
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants