Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: main function, full and light commands with subcommands #97

Merged
merged 15 commits into from
Oct 11, 2021
Merged

cmd: main function, full and light commands with subcommands #97

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5ec7b71
feat(node): add Node Type parsing from string
Wondertan Sep 29, 2021
b686db1
feat(node): new InitWith to allow custom configs
Wondertan Sep 29, 2021
90397e8
fix(node): ensure root is created before locking and improve logging
Wondertan Sep 29, 2021
dd08680
feat(cmd): start implementing CLI with Init command ing cmd packge us…
Wondertan Sep 29, 2021
308a05c
feat(cmd/celestia): main function with full and light commands
Wondertan Sep 29, 2021
af554fc
cmd: multiple improvements and ASCI art
Wondertan Sep 29, 2021
85be259
cmd: write error to stdout
Wondertan Sep 29, 2021
476ea14
fix(core): make core run kvapp by default
Wondertan Sep 30, 2021
da77456
fix(node): fs repo should load and save config over config path and t…
Wondertan Sep 30, 2021
9173724
fix(node): fix bug where Full Node was a light Node
Wondertan Sep 30, 2021
e781454
fix(node): track Start/Stop cancelation timeout with global timeout o…
Wondertan Sep 30, 2021
6661883
feat(cmd): start command
Wondertan Sep 30, 2021
769b747
feat(cmd/celestia): add start command
Wondertan Sep 30, 2021
f1c24ad
chore(fmt): make linter happy throughout ther project
Wondertan Sep 30, 2021
8082ae2
renes fixes
renaynay Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/celestia/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func run() error {
}

var rootCmd = &cobra.Command{
Use: "celestia [subcommand]",
Use: "celestia [ full || light ] [subcommand]",
Short: `
/ ____/__ / /__ _____/ /_(_)___ _
/ / / _ \/ / _ \/ ___/ __/ / __ /
Expand Down
6 changes: 3 additions & 3 deletions node/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ func InitWith(path string, tp Type, cfg *Config) error {
return err
}
log.Infof("Initializing %s Node Repository over '%s'", tp, path)
defer log.Info("Node Repository initialized")

err = initRoot(path)
if err != nil {
Expand Down Expand Up @@ -55,9 +54,9 @@ func InitWith(path string, tp Type, cfg *Config) error {
if err != nil {
return err
}
log.Info("Saving config")
log.Infow("Saving config", "path", cfgPath)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renaynay, What's the point of this log if it duplicates Initializing %s Node Repository over '%s' above? I mean it logs the path to the repo and cfg is constantly repo_path+config.toml, so not sure if there is a point to add this path here, but it does not hurt anyway.

} else {
log.Info("Config already exists")
log.Infow("Config already exists", "path", cfgPath)
}

// TODO(@Wondertan): This is a lazy hack which prevents Core Repository to be generated for all case, and generates
Expand All @@ -73,6 +72,7 @@ func InitWith(path string, tp Type, cfg *Config) error {
return core.Init(corePath)
}

log.Info("Node Repository initialized")
return nil
}

Expand Down
2 changes: 1 addition & 1 deletion node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (n *Node) Start(ctx context.Context) error {
err := n.app.Start(ctx)
if err != nil {
log.Errorf("starting %s Node: %s", n.Type, err)
return fmt.Errorf("node: faild to start: %w", err)
return fmt.Errorf("node: failed to start: %w", err)
}
log.Infof("started %s Node", n.Type)

Expand Down