Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(p2p): subscriber.Stop logs but ignores error from unregister topic validator #127

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

renaynay
Copy link
Member

This PR was caused by the fact that we now no longer ignore the error from unregister topic validator.

@Wondertan brought up a good point that the API of Subscriber doesn't enforce SetVerifier so it's possible to successfully Start the Subscriber without mounting a validator on it, but Stop would fail due to no validator being present.

This PR reverts the change and logs/ignores the error from unregister topic validator.

@codecov-commenter
Copy link

Codecov Report

Merging #127 (ac6f728) into main (a8ce731) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   65.01%   64.97%   -0.05%     
==========================================
  Files          39       39              
  Lines        3276     3275       -1     
==========================================
- Hits         2130     2128       -2     
- Misses        988      989       +1     
  Partials      158      158              
Files Coverage Δ
p2p/subscriber.go 43.20% <0.00%> (+0.52%) ⬆️

... and 1 file with indirect coverage changes

@Wondertan Wondertan merged commit 06f57bb into celestiaorg:main Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants