test(core): Fix core/listener tests #2882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
kind:testing
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
ramin
approved these changes
Oct 27, 2023
vgonkivs
approved these changes
Oct 27, 2023
Wondertan
reviewed
Oct 27, 2023
|
Turns out the fix was accidentally merged in #2881 |
auto-merge was automatically disabled
October 30, 2023 16:32
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we bumped go-header, it broke the listener tests and we didn't notice. I thought it was a deeper bug at first, but turns out we are now just returning an error that we were silently ignoring before (as it was only logged, not returned) in
subscriber.Stop.