chore!: check newChunk size #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 81.00% 81.22% +0.21%
==========================================
Files 7 7
Lines 516 522 +6
==========================================
+ Hits 418 424 +6
Misses 58 58
Partials 40 40
|
evan-forbes
previously approved these changes
Jun 20, 2023
staheri14
reviewed
Jun 23, 2023
staheri14
reviewed
Jun 23, 2023
rootulp
requested review from
staheri14 and
evan-forbes
and removed request for
adlerjohn
|
I just noticed #127 so tagging @Wondertan for review |
|
Based on #127 (comment) we may not want to return an |
Wondertan
reviewed
Jun 23, 2023
Comment on lines
+289
to
+308
| // SetCell sets a specific cell. The cell to set must be `nil`. Returns an error | ||
| // if the cell to set is not `nil` or newChunk is not the correct size. | ||
| func (ds *dataSquare) SetCell(x uint, y uint, newChunk []byte) error { | ||
| if ds.squareRow[x][y] != nil { | ||
| panic(fmt.Sprintf("cannot set cell (%d, %d) as it already has a value %x", x, y, ds.squareRow[x][y])) | ||
| return fmt.Errorf("cannot set cell (%d, %d) as it already has a value %x", x, y, ds.squareRow[x][y]) | ||
| } | ||
| if len(newChunk) != int(ds.chunkSize) { | ||
| return fmt.Errorf("cannot set cell with chunk size %d because dataSquare chunk size is %d", len(newChunk), ds.chunkSize) | ||
| } | ||
| ds.squareRow[x][y] = newChunk | ||
| ds.squareCol[y][x] = newChunk | ||
| ds.resetRoots() | ||
| return nil | ||
| } | ||
|
|
||
| // setCell sets a specific cell. | ||
| func (ds *dataSquare) setCell(x uint, y uint, newChunk []byte) { | ||
| // setCell sets a specific cell. setCell will overwrite any existing value. | ||
| // Returns an error if the newChunk is not the correct size. | ||
| func (ds *dataSquare) setCell(x uint, y uint, newChunk []byte) error { | ||
| if len(newChunk) != int(ds.chunkSize) { | ||
| return fmt.Errorf("cannot set cell with chunk size %d because dataSquare chunk size is %d", len(newChunk), ds.chunkSize) |
There was a problem hiding this comment.
What's the reason for having two setters? I don't remember
There was a problem hiding this comment.
My guess is the exported SetCell shouldn't have access to overwrite populated cells but the internal setCell should 🤷♂️
Wondertan
approved these changes
Jun 24, 2023
evan-forbes
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
Closes #127
Breaking b/c modifies the function signature of a public function:
SetCell