feat(eds): Flattened, FlattenedODS, Equals #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
commented
Jul 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage ? 79.01%
=======================================
Files ? 7
Lines ? 591
Branches ? 0
=======================================
Hits ? 467
Misses ? 74
Partials ? 50 |
Wondertan
reviewed
Jul 7, 2023
Wondertan
reviewed
Jul 7, 2023
rootulp
changed the title
Wondertan
approved these changes
Jul 7, 2023
Comment on lines
+282
to
+293
| if eds.originalDataWidth != other.originalDataWidth { | ||
| return false | ||
| } | ||
| if eds.codec.Name() != other.codec.Name() { | ||
| return false | ||
| } | ||
| if eds.chunkSize != other.chunkSize { | ||
| return false | ||
| } | ||
| if eds.width != other.width { | ||
| return false | ||
| } |
There was a problem hiding this comment.
I would combine in one multi line if, but thats a nit/preference.
evan-forbes
previously approved these changes
Jul 8, 2023
cmwaters
reviewed
Jul 10, 2023
cmwaters
previously approved these changes
Jul 10, 2023
rootulp
commented
Jul 10, 2023
rootulp
changed the title
rootulp
requested review from
staheri14 and
walldiss
and removed request for
walldiss and
evan-forbes
walldiss
reviewed
Jul 12, 2023
|
@cmwaters @staheri14 ready for re-review |
cmwaters
previously approved these changes
Jul 12, 2023
This reverts commit 2b22e3a.
|
Accidentally pushed a commit to this branch, when it should be a separate PR |
staheri14
approved these changes
Jul 12, 2023
cmwaters
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234
cc: @Wondertan @walldiss