Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
hsorby committed Sep 16, 2020
1 parent a76ec62 commit 93ee24a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ endif()
if(DEFINED BINDINGS_PYTHON AND BINDINGS_AVAILABLE AND Python_Development_FOUND)
set(LIBCELLML_BINDINGS_PYTHON "${BINDINGS_PYTHON}" CACHE BOOL ${_PARAM_ANNOTATION} FORCE)
elseif(BINDINGS_PYTHON)
message(WARNING "Python bindings requested but development files for Python or swig was not found!")
message(WARNING "Python bindings requested but development files for Python or SWIG were not found!")
endif()
unset(BINDINGS_PYTHON CACHE)

Expand All @@ -118,7 +118,7 @@ endif()
if(DEFINED PYTHON_COVERAGE AND PYTHON_COVERAGE_TESTING_AVAILABLE)
set(LIBCELLML_PYTHON_COVERAGE "${PYTHON_COVERAGE}" CACHE BOOL ${_PARAM_ANNOTATION} FORCE)
elseif(PYTHON_COVERAGE)
message(WARNING "Python coverage testing requested but the requirements were not found!")
message(WARNING "Python coverage testing requested but the Python and/or the Python Coverage module were not found!")
endif()
unset(PYTHON_COVERAGE CACHE)

Expand Down
1 change: 0 additions & 1 deletion src/bindings/interface/componententity.i
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ the structure."
%typemap(typecheck,precedence=SWIG_TYPECHECK_BOOL) bool { $1 = 1; }
%typemap(in) bool { $1 = PyObject_IsTrue($input) == 1; }


// Treat negative size_t as invalid index (instead of unknown method)
%extend libcellml::ComponentEntity {
ComponentPtr component(long index) const {
Expand Down

0 comments on commit 93ee24a

Please sign in to comment.