Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities: convertToDouble() should return NaN not Inf if the conversion cannot be done #576

Closed
agarny opened this issue Mar 17, 2020 · 0 comments · Fixed by #577
Closed

Utilities: convertToDouble() should return NaN not Inf if the conversion cannot be done #576

agarny opened this issue Mar 17, 2020 · 0 comments · Fixed by #577

Comments

@agarny
Copy link
Contributor

agarny commented Mar 17, 2020

Right now, we return Inf if convertToDouble() fails. However, I would expect NaN to be returned instead.
agarny added a commit to agarny/libcellml that referenced this issue Mar 17, 2020
@agarny
Utilities: have convertToDouble() return NaN if a conversion cann…
0c476e8 
…ot be done (cellml#576).
@agarny agarny mentioned this issue Mar 17, 2020
Merged
@agarny agarny linked a pull request Mar 17, 2020 that will close this issue
Utilities: have convertToDouble() return inf or -inf if a conversion cannot be done #577
Merged
agarny added a commit to agarny/libcellml that referenced this issue Mar 17, 2020
@agarny
Utilities: have convertToDouble() return nan, inf or -inf if …
f6c2497 
…a conversion cannot be done (cellml#576).
agarny added a commit to agarny/libcellml that referenced this issue Mar 17, 2020
@agarny
Utilities: have convertToDouble() return inf or -inf if a conve…
0e8d24a 
…rsion cannot be done (cellml#576).
agarny added a commit that referenced this issue Mar 19, 2020
@agarny
Utilities: have convertToDouble() return inf or -inf if a conve…
3942021 
…rsion cannot be done (closes #576).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Utilities: have convertToDouble() return inf or -inf if a conversion cannot be done agarny/libcellml
1 participant
@agarny