-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to interpret a model (initially algebraic and ODE models) #1220
Open
agarny
wants to merge
94
commits into
cellml:main
Choose a base branch
from
agarny:issue1218
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarny
force-pushed
the
issue1218
branch
7 times, most recently
from
April 8, 2024 07:04
1f42143
to
8b24d99
Compare
agarny
force-pushed
the
issue1218
branch
5 times, most recently
from
April 8, 2024 12:05
6195eff
to
0c80224
Compare
agarny
force-pushed
the
issue1218
branch
2 times, most recently
from
April 9, 2024 03:32
ac14aa0
to
1ec290b
Compare
agarny
force-pushed
the
issue1218
branch
3 times, most recently
from
April 10, 2024 23:50
54652a2
to
79df1ec
Compare
agarny
force-pushed
the
issue1218
branch
3 times, most recently
from
April 24, 2024 02:53
85611e0
to
c8eec99
Compare
Indeed, it is 15 to 20 times slower than the AST-based interpreter. Clearly, handling a stack is more costly than handling recursion.
This was only done to check that we do indeed get the same results... and we do.
Very important to make sure that we do indeed get the results we expect for all aspects of the interpreter.
agarny
force-pushed
the
issue1218
branch
3 times, most recently
from
April 24, 2024 06:30
0695749
to
35ef7c2
Compare
Rather than `std::vector<double>` (and then retrieve the data using `data()`. Indeed, some solvers may want to use temporary arrays (e.g., CVODE uses a temporary array of doubles for states and rates), which means that we need to be able to set them, if needed.
We now rely on the user providing them since some solvers may use temporary arrays to compute rates (e.g., CVODE uses temporary arrays for states and rates).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1218.