-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printer to print local children of imported components #591
Printer to print local children of imported components #591
Conversation
To be clear it is possible to do this at the moment. |
So is this a thing? What should I do in the tutorials? Use dummy variables or wait for an overloaded function? |
Either push ahead with the dummy variable method in the tutorial (this works now) or implement the proposed new API for the convenience methods and use them in the tutorials. Personally, I'm not sure how much of a convenience that these methods would be so I'd continue on the tutorials with the dummy variables. |
I'm going to revert the second commit, as discussion about workarounds there has obscured the actual bug ... I'll add the other as a "nice to have maybe" issue on its own. |
This reverts commit 9c701e0.
…rimoyle/libcellml into i590_print_model_with_imports
Wow, this PR went all over the show! In the end the bug was in the
|
This PR seems to be broken now. |
Just minor API change required I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from a few minor requests.
Addresses #590.
Additional to this test, I'd also expect to be able to specify this relationship (equivalence between imported variables) through the API. This isn't possible at the moment?
Also closes #609