Why is SHUTDOWN_TIMEOUT a constant? #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, definitely. Should be user-customizable. It's just nobody's asked yet ;) |
knewter
pushed a commit
to knewter/celluloid
that referenced
this pull request
Mar 8, 2013
Remove a constant per the request in celluloid#159. Replace with a class method which returns the same default value.
|
@tarcieri what else should go into this? Assuming there's some goal to make it customizable, but is it enough for someone to just redefine the return value of this method? It's at least better than a constant. I'm always wary of configurability with class methods because I never know where to put the state. |
|
@knewter looking at your PR, it should probably be an attr_accessor with a defined default. I can add that after-the-fact now that you've got the ball rolling |
tarcieri
added a commit
that referenced
this pull request
Mar 16, 2013
Why is SHUTDOWN_TIMEOUT a constant?
shadoi
pushed a commit
to shadoi/celluloid
that referenced
this pull request
Apr 18, 2013
Remove a constant per the request in celluloid#159. Replace with a class method which returns the same default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't this be configurable by user code instead of being constant (will get warning if redefined)?