Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskThread does not raise exceptions outside #189

Merged
merged 1 commit into from Mar 15, 2013

Conversation

halorgium
Copy link
Contributor

This will be the cause of many problems.
One result is the actor not dying when a method call raises an exception.

@tarcieri
Copy link
Member

Nice, yeah I expected it was something like that but never got around to something as simple as writing a spec. Thanks! ;)

@halorgium
Copy link
Contributor Author

Working on the fix now, but cross-Thread exceptions might be fun.

@halorgium
Copy link
Contributor Author

TaskThread#resume needs to raise an exception if the Thread raises one and dies.
Currently it is silently dropped.

@coveralls
Copy link

Coverage remained the same when pulling 91905bd on halorgium:task-thread-exceptions into d8c171f on celluloid:master.

View Details

tarcieri added a commit that referenced this pull request Mar 15, 2013
TaskThread does not raise exceptions outside
@tarcieri tarcieri merged commit 76d78b6 into celluloid:master Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants