Invalidate the block on call completion #245
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling a method on an
Actor
from a normalThread
, if you invoke a block after theCall
has completed, you will encounter a deadlock.This is due to the fact the sending
Thread
is no longer waiting for the block invocations.gist
If you are calling from an Actor, this behaviour works.
gist
This change invalidates the block for both scenarios.
We can allow block invocations in the actor case by only invalidating if the sender is a normal
Thread
.