Fix broken reactor interaction with timers. #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to get some feedback on this patch? |
|
All you have to do is wait :) |
|
I'm happy to submit some specs or other things if that helps. The sooner we figure this out the sooner we can move on to some other major issues with the reactor/actor design. |
tarcieri
added a commit
that referenced
this pull request
May 27, 2014
Fix broken reactor interaction with timers.
|
@ioquatix this looks like it might fix the problem. Hard to tell without proper specs |
|
@tarcieri I've already been working on specs for this, I'll try to make a PR some time this week. Sorry for not providing specs originally, I was just trying to get the issue fixed ASAP since it is a major blocker for me. |
|
@ioquatix cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #426