Rework pool specs #556
Merged
Rework pool specs #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
e2
commented
Apr 8, 2015
e2
commented
- made Pool and Spawner have more-or-less the same API
- specs are shared (with slight variations depending on group type)
- catch all Exceptions in Pool/Spawner
- timeouts better help identify the problem
- tests no longer flaky + faster
- include For review: "truly" synchronous sync calls #554 [close For review: "truly" synchronous sync calls #554]
| to_a.each { |thread| yield thread } | ||
| end | ||
|
|
||
| # For temp compatiblity with specs |
There was a problem hiding this comment.
How temporary is this, because I was definitely trying to avoid having this method.
There was a problem hiding this comment.
Until the specs are "stabily green" at least, and then until I've ported the "fixed" InternalPool - because this API may be unnecessary, but it's good at testing the stuff.
Either way there's probably more refactoring than this - and refactoring is done best when stuff is green - also because while refactoring you might find bugs, so it's best to do it on a "pre-release ready" codebase.
digitalextremist
pushed a commit
that referenced
this pull request
Apr 8, 2015
Since this is a work in progress, this is getting merged with temporary methods included.
|
With this PR I am seeing dramatic improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.