Celluloid::Registry#delete doesn't remove actors' reference from registry hash #76

Merged
merged 3 commits into from Aug 17, 2012

Conversation

Projects
None yet
4 participants
Contributor

jeremyvdw commented Aug 17, 2012

Based on this small script https://gist.github.com/3378835 featuring a SupervisionGroup spawning/killing actors, it seems odd to me that Celluloid::Registry#delete doesn't remove actors' reference from registry hash (and keep a reference to dead actors).
If it's on purpose, can you please explain why?

Thanks

This pull request passes (merged b9cb255 into c66f6b1).

Member

benlangfeld commented Aug 17, 2012

It's probably worth adding a test for this. I do believe it is a bug.

This pull request passes (merged ecb98d5 into c66f6b1).

tarcieri merged commit 2ce1a61 into celluloid:master Aug 17, 2012

1 check passed

default The Travis build passed
Details
Owner

tarcieri commented Aug 17, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment