Celluloid::Registry#delete doesn't remove actors' reference from registry hash #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's probably worth adding a test for this. I do believe it is a bug. |
tarcieri
added a commit
that referenced
this pull request
Aug 17, 2012
Celluloid::Registry#delete doesn't remove actors' reference from registry hash
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this small script https://gist.github.com/3378835 featuring a SupervisionGroup spawning/killing actors, it seems odd to me that Celluloid::Registry#delete doesn't remove actors' reference from registry hash (and keep a reference to dead actors).
If it's on purpose, can you please explain why?
Thanks