Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back fix for #696 from #612, in new ::Group::* convention. #763

Merged
merged 1 commit into from Mar 21, 2018

Conversation

zsiddique
Copy link

So this is a patch to make the fix from #696 and apply it to the 0-17-stable branch so a 0.17.4 release can be made.

This fix has been in the 0.18pre branch for a while. This would be easier than trying to resolve all the open issue in 0.18 branch.

@zsiddique
Copy link
Author

The test failures are due to ruby_dep requiring ruby 2.2 and greater but we have some test running against older ruby version. The one test passed was against 2.2.5. I think the fix for that is out of this scope

@PikachuEXE
Copy link

This very old build on 0.17 branch looks green
https://travis-ci.org/celluloid/celluloid/builds/103210007

But not sure what happens when re-run with latest

@tarcieri
Copy link
Member

tarcieri commented Dec 5, 2017

I restarted the build

@PikachuEXE
Copy link

$ rvm use jruby --install --binary --fuzzy
jruby is not installed - installing.
Searching for binary rubies, this might take some time.
Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Gemset '' does not exist, 'rvm jruby do rvm gemset create ' first, or append '--create'.
The command "rvm use jruby --install --binary --fuzzy" failed and exited with 2 during .

Not sure Travis issue or Travis config issue

@PikachuEXE
Copy link

It seems master is using a different version of jruby
https://travis-ci.org/celluloid/celluloid/builds/299878222

@myers
Copy link

myers commented Mar 20, 2018

@tarcieri could you retry the build. It appears rvm failed to find both rbx and jruby in the last attempt. I suspect from reading other issue reports this was a temporary failure.

I would really like to see a 0.17.4 as it would solve this long yak shave trip I've been on.

@tarcieri
Copy link
Member

@myers still can't find rbx-2. I'm ok with you deleting it, but if the tests pass it'd be nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants