New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example and stub function for pool #806
Add an example and stub function for pool #806
Conversation
I really like this. I think this is a good resolution to the pool errors that we ran into earlier and all the build errors are resolved as well. I think this is good to merge. |
@p-vinayak do you know why this pull request include Have you updated your fork & |
I added executable permissions for those scripts on my machine because the tests gave build errors since it was unable to run them. I got that same error locally and on travis CI and the tests seemed to pass the tests after I added the executable permissions to those scripts. I haven't updated the celluloid master branch on my fork yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change here looks good to me. It is good that we added an example for future users to reference
Provides a stub function which returns and error if the user is trying to invoke pool without requiring it.
Also added an example to demonstrate how pool works.