Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example and stub function for pool #806

Merged
merged 8 commits into from Dec 12, 2020
Merged

Add an example and stub function for pool #806

merged 8 commits into from Dec 12, 2020

Conversation

p-vinayak
Copy link
Contributor

Provides a stub function which returns and error if the user is trying to invoke pool without requiring it.

Also added an example to demonstrate how pool works.

@harsh183
Copy link
Member

I really like this. I think this is a good resolution to the pool errors that we ran into earlier and all the build errors are resolved as well. I think this is good to merge.

@dilumn
Copy link
Member

dilumn commented Dec 4, 2020

@p-vinayak do you know why this pull request include examples/configurations.rb & examples/supervisors_and_registry.rb files?
And why github shows them as empty files?

Have you updated your fork & p-vinayak-pool-example-and-stub-function branch already with Celluloid master?

@p-vinayak
Copy link
Contributor Author

p-vinayak commented Dec 5, 2020

I added executable permissions for those scripts on my machine because the tests gave build errors since it was unable to run them. I got that same error locally and on travis CI and the tests seemed to pass the tests after I added the executable permissions to those scripts.

I haven't updated the celluloid master branch on my fork yet.

Copy link
Member

@dilumn dilumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here looks good to me. It is good that we added an example for future users to reference

examples/pool.rb Show resolved Hide resolved
@dilumn dilumn merged commit 8770532 into celluloid:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants