This repository has been archived by the owner on Dec 7, 2018. It is now read-only.
Use celluloid-redis by default #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't really help anything for now but... sure? |
tarcieri
added a commit
that referenced
this pull request
Jul 6, 2013
Use celluloid-redis by default
|
/cc @tarcieri could you revert this? I belive it does more harm than good (Harm in: when someone assumes ::Redis.new uses the default adapter but it doesn't anymore when dcell is included) |
|
I think this is a Celluloid::Redis API issue more than anything. Could we change the API so this isn't a problem? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without celluloid-redis i had the annoyance that DCell would stop the Ruby Interpreter from shutting Down when calling exit.