Remove broken blocks #1068
Merged
Remove broken blocks #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you explain a bit more why this change is needed ? Which check "might cause segfault when quitting with interrupt" and why can't that segfault be avoided? |
|
I meant that there's an issue that might cause a segfault when quitting, and added a check to avoid that. There's more info in the linked issue, but basically when a corruption was detected, some of the data was deleted (for example all ancient blocks), but some were left there hanging (data from newer blocks). This caused syncing failures where the node became stuck. |
nategraf
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When DB is corrupted, removes all blocks that have no associated states.
Other changes
Added a check to avoid segfault when quitting with interrupt.
Tested
Only manual testing.
Related issues
Backwards compatibility