Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous error banner displayed when navigating to different screens #6314

Closed
jeanregisser opened this issue Dec 21, 2020 · 2 comments · Fixed by #6325
Closed

Previous error banner displayed when navigating to different screens #6314

jeanregisser opened this issue Dec 21, 2020 · 2 comments · Fixed by #6325
Assignees
@jeanregisser
Labels
bug Something isn't working Priority: P1 Critical wallet

Comments

@jeanregisser
Copy link
Contributor

Expected Behavior

Previous error shouldn't appear again when navigating to different screens.

Current Behavior

Previous error banner displayed when navigating to different screens.

Happened to Markus on iOS during today's bugapalooza testing v1.7
See details (logs and screenshots) in https://groups.google.com/a/clabs.co/g/support/c/9tQeyL2z8bk/m/CtWjaxmpAwAJ
@jeanregisser jeanregisser added bug Something isn't working wallet Priority: P1 Critical labels Dec 21, 2020
@jeanregisser
Copy link
Contributor Author

Related to this I also noticed the following and I suspect it might the same problem causing the 2 issues:

  1. Send myself some cUSD to my own address
  2. Notice the push notification displayed using the in-app blue banner: "Payment Received. You've received 0.01 Celo Dollars"
  3. Wait for the blue banner to disappear automatically
  4. Put the app in background
  5. Put the app back in the foreground
  6. Noticed the same blue banner with the message appears again.

@jeanregisser jeanregisser self-assigned this Dec 21, 2020
@jeanregisser jeanregisser mentioned this issue Dec 22, 2020
Merged
@jeanregisser
Copy link
Contributor Author

This is also reproducible this way:

  1. trigger an error (red) or message (blue) banner at the top. For instance by trying to send more funds than you have in your balance.
  2. wait for the banner to disappear by itself
  3. open the drawer menu and tap the "Account Key" item
  4. notice the last error or message banner is displayed again at the top

@mergify mergify bot closed this as completed in #6325 Dec 22, 2020
mergify bot pushed a commit that referenced this issue Dec 22, 2020
@jeanregisser
[Wallet] Fix last alert banner redisplayed on re-render (#6325)
d8bee97 
### Description

This fixes the regression described in #6314.

The change in #6230 made the underlying problem in `AlertBanner` more prominent as it caused the top level navigator to re-render on app state change (background/foreground/inactive) and hence the `AlertBanner`.

### Other changes

Globally mock `Animated.View` and `Animated.ScrollView` to prevent out of memory error when a ref is set.
See callstack/react-native-testing-library#539

Note: This change caused the Snapshot updates, because the styles are not flattened anymore for the mocked `Animated.View`.

### Tested

- Last alert is not redisplayed when navigating to different screens.
- New alert banner with same content can still be redisplayed when dispatched (causing a state change).

### Related issues

- Fixes #6314

### Backwards compatibility

Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanregisser jeanregisser

Labels
bug Something isn't working Priority: P1 Critical wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Wallet] Fix last alert banner redisplayed on re-render celo-org/celo-monorepo
1 participant
@jeanregisser