[Wallet] Fix "Shake-to-Contact" triggered while app is in background #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
requested review from
cmcewen,
i1skn and
jmrossy
as code owners
This was referenced Dec 21, 2020
mergify bot
pushed a commit
that referenced
this pull request
Dec 22, 2020
### Description This fixes the regression described in #6314. The change in #6230 made the underlying problem in `AlertBanner` more prominent as it caused the top level navigator to re-render on app state change (background/foreground/inactive) and hence the `AlertBanner`. ### Other changes Globally mock `Animated.View` and `Animated.ScrollView` to prevent out of memory error when a ref is set. See callstack/react-native-testing-library#539 Note: This change caused the Snapshot updates, because the styles are not flattened anymore for the mocked `Animated.View`. ### Tested - Last alert is not redisplayed when navigating to different screens. - New alert banner with same content can still be redisplayed when dispatched (causing a state change). ### Related issues - Fixes #6314 ### Backwards compatibility Yes
|
Hi @jeanregisser We have verified issue on V1.7.2(1004294329) & Test Flight build V1.7.2(39) and found that issue is fixed now user is not redirected to Contact screen if app is running in background. Also, we have checked this issue on Android 4 os and found crash, FYI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix "Shake-to-Contact" triggered while app is in background, which caused some confusion (see #6208)
Other changes
None
Tested
Tested Contact screen is not triggered while shaking the device with the app in the background.
Related issues
Backwards compatibility
Yes.