Scripts for verifying bytecodes #5111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-chrzan
requested review from
aaronmgdr,
cmcewen,
i1skn,
jeanregisser,
jmrossy and
timmoreton
m-chrzan
force-pushed
the
m-chrzan/bytecode-scripts
branch
from
09aedee
to
a434400
Compare
m-chrzan
force-pushed
the
m-chrzan/verify-release
branch
from
8ce407b
to
0dbf3bb
Compare
m-chrzan
force-pushed
the
m-chrzan/bytecode-scripts
branch
from
65bcab8
to
a3333ab
Compare
yorhodes
force-pushed
the
m-chrzan/verify-release
branch
from
ed84b16
to
8a2df9e
Compare
yorhodes
force-pushed
the
m-chrzan/bytecode-scripts
branch
from
5c8255f
to
f3c0e87
Compare
yorhodes
force-pushed
the
m-chrzan/bytecode-scripts
branch
from
8456dcc
to
180d5d8
Compare
#5236) * Simplify contract release process commands and verify release * Revert useful info removals
yorhodes
force-pushed
the
m-chrzan/bytecode-scripts
branch
from
e2891e8
to
24ea9fb
Compare
nambrot
reviewed
Oct 8, 2020
| # We fetch via HTTPS instead of SSH to avoid the interactive "do you | ||
| # trust the RSA key fingerprint" prompt. | ||
| git remote add origin-https https://github.com/celo-org/celo-monorepo.git | ||
| git fetch origin-https rc1 |
There was a problem hiding this comment.
At this point, this is incorrect, as master needs to compare against release 1.
I believe there are only 3 options:
- Adjust the migrations to proxy linked libraries and then checkout the release-1 branch here
- Create a special case for release 2, where creating the bytecode involves
2.1 Deploying RC1
2.2 Creating the proposal for release 1
2.3 Get through the proposal for release 1
2.4 Continue - Not add this to CI until 1. is done
.circleci/config.yml
Outdated
| command: | | ||
| ./scripts/ci_check_if_test_should_run_v2.sh @celo/protocol | ||
| - run: | ||
| name: Verify bytecodes between RC1 and current branch |
There was a problem hiding this comment.
Suggested change
| name: Verify bytecodes between RC1 and current branch | |
| name: Verify bytecodes between most recent release and current branch |
| # deploy new contracts and generate governance proposal for upgrade | ||
| yarn truffle exec --network development ./scripts/truffle/make-release.js --build_directory build/ --report report.json --proposal proposal.json --initialize_data example-initialize-data.json' | ||
| NETWORK=${"baklava"|"alfajores"|"mainnet"} | ||
| RELEASE="celo-core-contracts-v${N}.${NETWORK}" |
There was a problem hiding this comment.
Suggested change
| RELEASE="celo-core-contracts-v${N}.${NETWORK}" | |
| RELEASE="celo-core-contracts-v${N-1}.${NETWORK}" |
I think?
There was a problem hiding this comment.
I was trying to generalize this and add the specific instruction in backward compatibility check but this is probably the primary use case
| RELEASE="celo-core-contracts-v${N}.${NETWORK}" | ||
| # A -f boolean flag can be provided to use a forno full node to connect to the provided network | ||
| # A -r boolean flag should be provided if this is the first release (before linked libraries were proxied) | ||
| yarn verify-deployed -n $NETWORK -b $RELEASE -r -f |
There was a problem hiding this comment.
I don't think it's in scope for this PR, but for these critical scripts, I'm not sure I'm a fan of these shortened flags, wdyt?
There was a problem hiding this comment.
will address in followup PR
nambrot
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two bash wrappers around
verify-bytecodes:verify-deployedchecks that the current Celo contracts correspond to Solidity sources on a given branch.verify-releasechecks that after executing a given proposal, the onchain contracts will correspond to Solidity sources on a given branch.Other changes
Added a
-fflag to several of our bash scripts, and modifiedtruffle-configto take a--fornoparameter that allows Truffle scripts to run with a Forno provider on testnets/the mainnet for which a Forno instance exists.Added comments, cleaned up scripts.
Tested
verify-deployed
verify-release
Related issues
Backwards compatibility
+1