Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add positive output to the verify-bytecodes script #5398

Merged
merged 11 commits into from
Oct 16, 2020

Conversation

m-chrzan
Copy link
Contributor

@m-chrzan m-chrzan commented Oct 16, 2020

Description

Previously the script would just exit with code 0 and no stdout output about success. Added logs reporting which contracts have been checked and at which address on the network.

Other changes

getImplementationAddress was previously returning pre-release 1 library addresses without a "0x" prefix, fixed this for consistency in logs.

Improved the documentation comment in verify-bytecodes.ts.

Tested

yarn verify-bytecodes -b rc1 -n rc1 -r -f succeeds outputs the new logs.

Related issues

Backwards compatibility

Only cosmetic script change.

@nambrot nambrot mentioned this pull request Oct 16, 2020
60 tasks
@ewilz
Copy link
Contributor

ewilz commented Oct 16, 2020

Do we need to add the same flag inside verify-release.sh as well, or is that different?
In thinking about suppressing the logs for these scripts I was thinking of adding an optional --verbose flag. would having both --quiet and --verbose be confusing?

@nambrot nambrot added the automerge Have PR merge automatically when checks pass label Oct 16, 2020
@mergify mergify bot merged commit ace4af2 into master Oct 16, 2020
@mergify mergify bot deleted the m-chrzan/verify-bytecodes-positive branch October 16, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants