Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade our bip39 to TS version #5697

Merged
merged 49 commits into from
Nov 6, 2020
Merged

Upgrade our bip39 to TS version #5697

merged 49 commits into from
Nov 6, 2020

Conversation

cmcewen
Copy link
Contributor

@cmcewen cmcewen commented Nov 3, 2020

Description

Library updates include bip39 + randombytes

cmcewen and others added 23 commits November 2, 2020 08:15
* Fix Xcode12 cli build

Xcode 12 now tries to build both arm64 and x86_64 slices for the simulator
See:
- https://stackoverflow.com/a/63955114/158525
- facebook/react-native#29984
- https://apontious.com/2020/08/23/arm-wrestling-your-ios-simulator-builds/

Also upgrade CocoaPods

* Use Xcode 12.1.0 on CirclCI

* Fix Android e2e step on CircleCI

See https://support.circleci.com/hc/en-us/articles/360048152911-Java-Builds-Fail-With-Unrecognized-VM-option-UseCGroupMemoryLimitForHeap-
yarn.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍 🥇
Could you update the description of the PR with more context about why it's needed (for posterity)?

packages/mobile/package.json Outdated Show resolved Hide resolved
@jeanregisser jeanregisser added the automerge Have PR merge automatically when checks pass label Nov 5, 2020
@mergify mergify bot merged commit 5d5e6a5 into master Nov 6, 2020
@mergify mergify bot deleted the cmcewen/bip39-ts branch November 6, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants