Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payments to unverified numbers #5827

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Fix payments to unverified numbers #5827

merged 3 commits into from
Nov 12, 2020

Conversation

annakaz
Copy link
Contributor

@annakaz annakaz commented Nov 12, 2020

Description

Unused and undefined name was causing sending payments to unverified numbers to fail

We used to use someone's name in the invite text but no longer do

Tested

Sent a payment to an unverified number

Related issues

@annakaz annakaz added wallet automerge Have PR merge automatically when checks pass labels Nov 12, 2020
@annakaz annakaz requested a review from a team November 12, 2020 01:01
@mergify mergify bot merged commit ac111a9 into master Nov 12, 2020
@mergify mergify bot deleted the annakaz/escrow branch November 12, 2020 01:52
i1skn pushed a commit that referenced this pull request Nov 12, 2020
### Description

 Unused and undefined name was causing sending payments to unverified numbers to fail

We used to use someone's name in the invite text but no longer do

### Tested

Sent a payment to an unverified number

### Related issues

- Fixes #5823
@Lss-Ankit
Copy link

Lss-Ankit commented Nov 19, 2020

Hi @tarikbellamine i Have verified this issue latest test flight build v1.5.5 (34) and Android play store internal build v1.5.5 (1004294323) and observe the following

  • User is able to send the payment through escrow without any error
  • Send & Invite button is shown on sending dollar page when user not verified phone number

Devices: iPhone 6+ (12.4.5) , Vivo v11 pro (10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't send to unverified user
3 participants