Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lib to fix pixel email issue #5837

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Upgrade lib to fix pixel email issue #5837

merged 6 commits into from
Nov 13, 2020

Conversation

cmcewen
Copy link
Contributor

@cmcewen cmcewen commented Nov 12, 2020

Description

We weren't able to attach logs on certain devices. I suspect this PR fixed the issue, though I need someone else to confirm since it works fine on my device

fixes #5730

@i1skn
Copy link
Contributor

i1skn commented Nov 12, 2020

For me the error, when opening Gmail disappeared, but the logs are not attached still. Also now I can send using Fastmail, but without logs as well.

@i1skn
Copy link
Contributor

i1skn commented Nov 12, 2020

I've used plural attachements as in example here https://github.com/chirag04/react-native-mail#example and now it works for me. @cmcewen PTAL

@cmcewen cmcewen added the automerge Have PR merge automatically when checks pass label Nov 13, 2020
@mergify mergify bot merged commit a3fd3d3 into master Nov 13, 2020
@mergify mergify bot deleted the cmcewen/pixel-email branch November 13, 2020 03:36
i1skn pushed a commit that referenced this pull request Nov 13, 2020
### Description

We weren't able to attach logs on certain devices. I suspect [this PR](chirag04/react-native-mail#161) fixed the issue, though I need someone else to confirm since it works fine on my device

fixes #5730
@Lss-Ankit
Copy link

Hi @tarikbellamine i Have verified this issue latest test flight build v1.5.5 (34) and Android play store internal build v1.5.5 (1004294323) and observe the following

  • User is able to attach the logs from contact screen

Devices: Google Pixel XL (8.1), Google pixel 4a(11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pixel Phones are unable to attach logs
4 participants