CIP [0014]: Add new exchange function to allow buying fixed amount of tokens for maximum price

[zviadm]

No description provided.

[asaj]

This seems like a great idea and should be pretty straightforward to implement!

[asaj]

Wdyt of the following function signatures, and deprecating the exchange function?

function buy(uint256 amount, uint256 minSellAmount, bool buyGold);
function sell(uint256 amount, uint256 minBuyAmount, bool sellGold);

cc @tkporter

[zviadm]

This works, and it should cover all the use cases that I mentioned in the CIP.

[tkporter]

@asaj PR will be out soon

Shouldn't buy enforce a maxSellAmount instead of minSellAmount?

function buy(uint256 amount, uint256 maxSellAmount, bool buyGold);

edit: ah I see now the CIP says this too

[tkporter]

PR is up at celo-org/celo-monorepo#4580

[martinvol]

Shall we close as celo-org/celo-monorepo#4580 got merged?

[nambrot]

Agreed @tkporter ?

[prestwich]

Closing as obsolete

[tkporter]

Whoops didn't see this-- is there a reason why we'd close instead of merge?

[prestwich]

hey @tkporter trying to clean up stale PRs a bit. I asked Nam's opinion but probably ought to have pinged you as well. If this accurately documents current behavior we should clean it up and include it

[tkporter]

Yeah this was implemented in celo-org/celo-monorepo#4580. For cleaning up, would that involve making some changes to fit the template https://github.com/celo-org/celo-proposals/blob/master/CIPs/cip-template.md?

[prestwich]

For cleaning up, would that involve making some changes to fit the template https://github.com/celo-org/celo-proposals/blob/master/CIPs/cip-template.md?

Yes, assuming it's already implemented, this should be

category: Ring 1
type: Standards Track
status: Final