Merge pull request #7 from mmv/master

Protect against libraries that extend Array.prototype
cemerick · Nov 1, 2013 · c95b291 · c95b291
2 parents 7e6da09 + 76123ec
commit c95b291
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/diffview.js b/diffview.js
@@ -188,10 +188,10 @@ diffview = {
 		node2.setAttribute("href", "http://github.com/cemerick/jsdifflib");
 
 		tdata.push(node = document.createElement("tbody"));
-		for (var idx in rows) node.appendChild(rows[idx]);
+		for (var idx in rows) rows.hasOwnProperty(idx) && node.appendChild(rows[idx]);
 
 		node = celt("table", "diff" + (inline ? " inlinediff" : ""));
-		for (var idx in tdata) node.appendChild(tdata[idx]);
+		for (var idx in tdata) tdata.hasOwnProperty(idx) && node.appendChild(tdata[idx]);
 		return node;
 	}
-}
+}