Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Update name of trace sampled field recognized by Stackdriver Logging agent. #181

Merged

Conversation

sebright
Copy link
Contributor

The field uses underscores instead of camel case. See
GoogleCloudPlatform/fluent-plugin-google-cloud#307.

Copy link

@g-easy g-easy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They said they would fix this in the next major release, so up to you if you want to change it now (and then change it back later?)

@sebright
Copy link
Contributor Author

sebright commented May 1, 2019

I would rather merge this now and then revert it once #307 is fixed and available in the logging agent, especially since the fix will be backwards compatible.

@sebright sebright merged commit 780a522 into census-ecosystem:master May 1, 2019
@sebright sebright deleted the update-trace-sampled-key-name branch May 1, 2019 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants