-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in naming of special field for trace sampling decision #307
Comments
…agent. The field uses underscores instead of camel case. See GoogleCloudPlatform/fluent-plugin-google-cloud#307.
Hmm... That is not intended. Thanks for the heads up! We'll fix it in the next major release (since it would introduce some backward incompatible change). |
Could we not support both and deprecate the one with the underscore? |
@igorpeshansky - Like supporting both but having |
…agent. (#181) The field uses underscores instead of camel case. See GoogleCloudPlatform/fluent-plugin-google-cloud#307.
@qingling128 I'm assuming the work left is to is just a cleanup. Let's make sure it gets tracked if it's necessary. |
Yes, this is already tracked in the major release cut change list. |
I noticed that the special field for the trace sampling decision uses underscores (
logging.googleapis.com/trace_sampled
), but other special fields use camel case (e.g.,logging.googleapis.com/spanId
,logging.googleapis.com/sourceLocation
). I don't know if this inconsistency is an issue, though.The text was updated successfully, but these errors were encountered: