This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Support exporting Exemplar. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased against master, PTAL. |
rghetia
reviewed
Apr 25, 2019
metrics.go
Outdated
| for _, v := range attachments { | ||
| switch v.(type) { | ||
| case string: | ||
| pbAttachments = append(pbAttachments, toPbStringAttachment(v)) |
There was a problem hiding this comment.
case string and default has same action. may be remove case string?
rghetia
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until the exemplar PRs at core library are merged.